Re: Bug with URL-decoding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 06, 2010 at 10:06:50PM +0000, Dave Abrahams wrote:

> $ cd /tmp
> $ mkdir x+y
> $ cd x+y
> $ git init
> $ cd ..
> $ git clone file:///tmp/x%2By zz  # <==== ERROR
> $ git clone file:///tmp/x+y zz # <====== OK
> 
> Funny characters do come up in names, especially in test suites

Yeah, at this point file:// is more or less just an alias for a straight
path (and ssh:// an alias for "host:path" syntax). We correctly
percent-decode http:// URLs because we just hand them to curl, which
does the right thing. We should be decoding these ones when we pick
apart the URL components.

Patch series to follow:

  [1/2]: make url-related functions reusable
  [2/2]: decode file:// and ssh:// URLs

With these patches, you can do:

  git clone file:///tmp/x%2By

or

  git clone /tmp/x+y

The former will clone into "x%2By". Which I'm not even sure is wrong, so
I left it as-is.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]