On Mon, Apr 26, 2010 at 05:06:55PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > I do wonder if it might be less error-prone to have: > > > > test_expect_success PREREQ1 PREREQ2 'desc' 'test' > > > > instead of > > > > test_expect_success 'PREREQ1 PREREQ2' 'desc' 'test' > > Spot what is wrong with this: > > test_expect_success make sure we have the repo ' > test -d .git > ' To me it's easy to spot, but there is nothing wrong with it that the shell will spot, so that is a downside. Whatever we go with, it would perhaps be less error prone to set "NOPREREQ1" when we don't have PREREQ1, and check that either $1 or NO$1 is set when checking prerequisites. But that is probably just over-engineering. This is not an error we have seen a lot of, and it is not that hard to spot with code review. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html