On Wed, Apr 21, 2010 at 08:38:06AM -0500, Jonathan Nieder wrote:
> Alas, I didn’t notice the thread with the almost identical patch [1]
> before writing this one.
>
> Since I am painting it, I prefer this way. I find it intuitive and
> can’t really see where the fuss about using some other coding style
> came from. So I would be very happy if someone who does understand
> the fuss could come up with a comment to add to the commit message
> about this. :)
I liked commas better, but since you are doing the work of writing the
patches, I will let it go. :)
I do wonder if it might be less error-prone to have:
test_expect_success PREREQ1 PREREQ2 'desc' 'test'
instead of
test_expect_success 'PREREQ1 PREREQ2' 'desc' 'test'
which should just be something like
while test $# -gt 2; do
test_have_prereq "$1" || skip=t
shift
done
But if you think that's dumb, just ignore it. It is really not worth
spending that much time on.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html