diff_tree_sha1 always return 0, so comparing the return value of it make no sense. Just delete the comparison to make code reader clear. Signed-off-by: Bo Yang <struggleyb.nku@xxxxxxxxx> --- revision.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/revision.c b/revision.c index f4b8b38..8caca99 100644 --- a/revision.c +++ b/revision.c @@ -329,9 +329,7 @@ static int rev_compare_tree(struct rev_info *revs, struct commit *parent, struct tree_difference = REV_TREE_SAME; DIFF_OPT_CLR(&revs->pruning, HAS_CHANGES); - if (diff_tree_sha1(t1->object.sha1, t2->object.sha1, "", - &revs->pruning) < 0) - return REV_TREE_DIFFERENT; + diff_tree_sha1(t1->object.sha1, t2->object.sha1, "", &revs->pruning); return tree_difference; } -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html