Ed Santiago <santiago@xxxxxxxxxx> writes: > Question mark character appears to be valid in a CVS tag, > but not a git one. Remove it. Leave open the possibility that there may > be more such characters; and comment (FIXME) that we may want to replace > those instead of removing them. I agree that people may want to optionally replace them to avoid mapping two originally different tags into the same one. Does your regexp chain check other invalid refname sequences, such as ".name", "na..me", etc.? > Also: if git tag command fails, do not include $! in our > error message: it is not useful after system(), and will > only serve as a red herring. > --- Sign-off? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html