On Sat, 10 Apr 2010, Junio C Hamano wrote:
"Henrik Grubbström (Grubba)" <grubba@xxxxxxxxxx> writes:
The diff_queue_struct provided by diff_flush() is raw, and needs to be
filtered through diff_unmodified_pair() before being used.
This is already done by most of the other functions operating on
diff_queue_struct called by diff_flush().
That is true but only if you are letting the diff front-end to feed
unmodified pairs to begin with, e.g. --find-copies-harder. I don't think
the internal caller in wt-status does that.
I don't think the patch is wrong nor it would hurt, but I am puzzled why
you needed this patch.
Well, it's a prerequisite for the diff: Filter files that have changed...
patch, albeit apparently not sufficient (yet).
--
Henrik Grubbström grubba@xxxxxxxxxx
Roxen Internet Software AB grubba@xxxxxxxxx