Re: [PATCH 0/2] fix weird git --paginate behavior

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

> Nguyễn Thái Ngọc Duy wrote:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
>> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
>
> Thanks for posting this series.  I had not read it in full before.
>
> The series is very long and it is hard to make certain it does not
> introduce regressions.  Here is my idea for working around this: the
> idea is to grab patches from the series to form short, independently
> justifiable mini-series.

Thanks for trying out your idea.

I've been having trouble reviewing this series.  I can read bits and
pieces and find things that I mostly agree with, or things that I find
questionable.  But in either case, I cannot be sure about my judgement
without having a clear idea of where the series is trying to go upfront.

While a re-roll will certainly give us a chance to review the series
"cover-to-cover", it would make it much easier to swallow if this can be
split into independently digestable bite-sized pieces.  I am somewhat
skeptical if a major part of the series will become that smaller,
though...

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]