On Tue, Mar 23, 2010 at 21:19, Johannes Sixt <j6t@xxxxxxxx> wrote: > On Dienstag, 23. März 2010, Fredrik Kuivinen wrote: >> On Wed, Mar 17, 2010 at 22:28, Johannes Sixt <j6t@xxxxxxxx> wrote: >> That xmalloc and xrealloc aren't thread-safe feels a bit fragile. >> Maybe we should try to fix that. > > The point of this assessment was to find out whether this is necessary (and > whether something else that is not thread-safe is used). It may not be necessary now, but my point was that by having thread-unsafe xmalloc and xrealloc it is a bit too easy to introduce new bugs. >> > ---------- >> > upload_pack:create_pack_file(): >> ... >> sha1_to_hex is also called by the parent and the current >> implementation of that function is not thread-safe. sha1_to_hex is >> also called by some paths in the revision machinery, but I don't know >> if it will ever be called in this particular case. > > sha1_to_hex is only called by the parent when the async procedure is not used. Yes, you are right. - Fredrik -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html