The goal of this series is to fix async procedures to the extent that
t5530-upload-pack-error.sh passes on Windows.
The problem is that on Windows async procedures are run in threads (due
to the lack of fork()), and a die() call from an async procedure tears
down the whole process while on POSIX only the async procedure is
terminated.
The approach taken is to use a custom die routine that exits only the
thread when it detects that it is not called from the main procedure.
As a bonus, the threaded async infrastructure now uses pthreads instead
of Windows specific API, and can be enabled on POSIX as well through a
new compile-time option.
Quite frankly, I don't quite know what to do with this series. On the
one hand, it is a clean-up, but in practice it is not relevant whether
die() kills only the async thread or the whole process because all
callers of async die() themselves anyway when the async procedure died.
On the other hand, it does enable threaded async procedures on POSIX...
Johannes Sixt (6):
Modernize t5530-upload-pack-error.
Make report() from usage.c public as vreportf() and use it.
Fix signature of fcntl() compatibility dummy
Windows: more pthreads functions
Reimplement async procedures using pthreads
Dying in an async procedure should only exit the thread, not the
process.
Makefile | 5 +++
compat/mingw.h | 2 +-
compat/win32/pthread.c | 8 ++++
compat/win32/pthread.h | 25 ++++++++++++++
fast-import.c | 8 ++---
git-compat-util.h | 1 +
http-backend.c | 5 +--
run-command.c | 75 ++++++++++++++++++++++++++++++++----------
run-command.h | 8 +++-
t/t5530-upload-pack-error.sh | 18 +++++-----
usage.c | 10 +++---
11 files changed, 121 insertions(+), 44 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html