Aside from handling of SIGPIPE, there was no reason for verify-tag
to run in a separate process.
Not much advantage to this I can see. It just simplifies things
a little.
Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
---
Rebased to remove the churn from patch 1, as suggested by Johannes.
Thanks.
The new series has only 4 patches:
[PATCH 2/5] verify-tag: use sigchain library to block SIGPIPE
[PATCH 3/5] Expose verify_tag()
[PATCH 4/5 v2] tag -v: Do not spawn a separate process for verify-tag
[PATCH 5/5] verify_tag_signature(): let caller look up tag object sha1
builtin/tag.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/builtin/tag.c b/builtin/tag.c
index 4ef1c4f..d138e0c 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -147,11 +147,7 @@ static int delete_tag(const char *name, const char *ref,
static int verify_tag(const char *name, const char *ref,
const unsigned char *sha1)
{
- const char *argv_verify_tag[] = {"git-verify-tag",
- "-v", "SHA1_HEX", NULL};
- argv_verify_tag[2] = sha1_to_hex(sha1);
-
- if (run_command_v_opt(argv_verify_tag, 0))
+ if (verify_tag_signature(sha1_to_hex(sha1), 1))
return error("could not verify the tag '%s'", name);
return 0;
}
--
1.7.0.2
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html