Hi, I noticed that ‘git tag -v’ runs git-verify-tag (dashed form), and while fixing that, I thought, why not make cmd_tag() run verify_tag() directly? Here is what that would look like. The performance impact is pretty negligible: t/t7004-tag.sh is about 2% faster after the change here (with hot or cold cache, it doesn’t matter). What do you think? Jonathan Nieder (5): tag: Run ‘git verify-tag’ using its undashed name verify-tag: use sigchain library to block SIGPIPE Expose verify_tag() tag: Do not spawn a separate process for verify-tag verify_tag_signature(): let caller look up tag object sha1 Makefile | 1 + builtin/tag.c | 6 +-- builtin/verify-tag.c | 84 ++++------------------------------ tag.h | 2 + builtin/verify-tag.c => verify-tag.c | 49 ++++---------------- 5 files changed, 22 insertions(+), 120 deletions(-) copy builtin/verify-tag.c => verify-tag.c (61%) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html