Re: [PATCH] Prompt for a username when an HTTP request 401s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 19 Mar 2010, Tay Ray Chuan wrote:

When an HTTP request returns a 401, Git will currently fail with a confusing message saying that it got a 401.  This changes http_request to prompt for the username and password, then return HTTP_REAUTH so http_get_strbuf can try again.  If it gets a 401 even when a user/pass is supplied, http_request will now return HTTP_NOAUTH which remote_curl can then use to display a more intelligent error message that is less confusing.

how are you getting 401s? Recently, git set the CURL_AUTH_ANY option, so if the correct credentials are passed, curl should have "hid" the 401 from us.

That's correct. It should hide the 401 in the sense that it should try to continue and do the correct authentication procedure and only if that fails it should end up with an actual 401 end result.

--

 / daniel.haxx.se

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]