On Tue, Mar 09, 2010 at 04:58:04PM -0800, Junio C Hamano wrote: > > With the current code, gitk (which calls "log --pretty=raw") barfs on a > > repository with log.decorate turned on. > > Yuck. Do you mean we would need _at least_ something like this? I am Yeah, your patch fixes the problem. > undecided if we should limit to FMT_RAW if that is the case, though. > Reading from "git log --pretty=raw" is just as unkosher as reading from > "git log --pretty=oneline", but a bigger question is do we still have > enough plumbing support to replace them, or Porcelain "log" has advanced > too much too quickly, leaving plumbing "rev-list" behind. It looks like the switch to "git log" in gitk came from c961b22 (gitk: Use git log and add support for --left-right, 2007-07-09), which in turn comes from: http://article.gmane.org/gmane.comp.version-control.git/51977 It looks like rev-list supports --left-right properly now (not sure if it did back then or not), so if that was the only reason, it could probably switch back. I seem to recall there are other reasons to use "log" in a script, but I can't remember any off the top of my head. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html