Re: What's cooking in git.git (Mar 2010, #02; Sun, 07)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 08, 2010 at 01:20:32AM -0800, Junio C Hamano wrote:

> After thinking about this a bit more, I do not think it is a good idea to
> disable configured decoration when an explicit --pretty is given.  A patch
> to do so would be a trivial two-liner:
> [...]
> but there is one big difference between notes and decoration.  Decorations
> are designed to be a small, one-per-ref tokens that would sit well on a
> line that already has other essential informations, while notes are a lot
> louder "in your face" annotations that occupy line(s) on their own.

True, but turning off configured decorations also helps scripts. I think
we can all agree that normal "git log" is not supposed to be consumed by
scripts, but should "git log --pretty=raw" turn off configured
decorations?

With the current code, gitk (which calls "log --pretty=raw") barfs on a
repository with log.decorate turned on.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]