Stephen Boyd <bebarino@xxxxxxxxx> writes: > On 03/05/2010 06:21 PM, Junio C Hamano wrote: >> This reveals that --to does not follow the usual rule to override >> corresponding configuration. Is that really what we want? IOW, when the >> command line says scipient, shouldn't we stop sending to recipient that >> comes from the configuration? How else would a user override this? >> >> So I guess the topic wasn't ready for 'next' yet, after all. > > The same applies to the fomat.headers and format.cc config options. How > is this different? Not different. Perhaps we should fix them now you noticed they share the same problem? An obvious alternative is to keep format.to not get overriden by --to as the original patch did; that would at least make the handling between config and option consistent inside the command, but at the same time, it means format-patch behaves differently from everything else in git. I don't have strong preference either way myself, and while I know "fixing" the ones you listed would affect existing users, I have this suspicion that it wouldn't be too big a problem. After all, format-patch does not _send_ mails; these MUA-like "features" doesn't belong to the program, and nobody should be relying on them heavily in the first place. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html