Re: [PATCH] Add tests for git format-patch --to and format.to config option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes:

> +test_expect_success 'additional command line to' '
> +
> +	git format-patch --to="S. E. Cipient <scipient@xxxxxxxxxxx>" --stdout master..side | sed -e "/^\$/q" >patch11 &&
> +	grep "^To: R. E. Cipient <rcipient@xxxxxxxxxxx>,\$" patch11 &&
> +	grep "^ *S. E. Cipient <scipient@xxxxxxxxxxx>\$" patch11
> +'

This reveals that --to does not follow the usual rule to override
corresponding configuration.  Is that really what we want?  IOW, when the
command line says scipient, shouldn't we stop sending to recipient that
comes from the configuration?  How else would a user override this?

So I guess the topic wasn't ready for 'next' yet, after all.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]