Re: [PATCHv4 6/6] is_submodule_modified(): clear environment properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Giuseppe Bilotta schrieb:
> On Wed, Feb 24, 2010 at 9:06 AM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:
>> Giuseppe Bilotta schrieb:
>>> +     const char *env[local_repo_env_size+2];
>> Variable sized arrays are prohibited.
> 
> Ah, sorry. Is alloca() allowed? I don't see it being used anywhere
> else in the code, and malloc would be a little too much for this case.

in cache.h:

#define LOCAL_REPO_ENV_CAPACITY 20
const char *const l_r_e[];

in environtment.c:

const char *const l_r_e[LOCAL_REPO_ENV_CAPACITY] = { ..., NULL };

and the compiler will croak if the constant becomes too small. (Oh, I
know, you must use the 'inconsistent mode' that I nit-picked if you use
this approach.)

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]