Giuseppe Bilotta schrieb: > + const char *env[local_repo_env_size+2]; Variable sized arrays are prohibited. > struct strbuf buf = STRBUF_INIT; > > + /* Copy local_repo_env to env, letting i > + rest at the last NULL */ > + while (env[i] = local_repo_env[i]) > + ++i; /* do nothing */ > + This looks very inconsistent: At the one hand, you use l_r_e_size to allocate the space, but then you iterate over it assuming that the list is (also) NULL-terminated. But this is only a minor nit. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html