Re: [PATCH v5 06/11] rebase -i: invoke post-rewrite hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:

> +test_expect_success 'git rebase -i (unchanged)' '
> +	git reset --hard D &&
> +	clear_hook_input &&
> +	FAKE_LINES="1 2" test_must_fail git rebase -i --onto A B &&

This

> ...
> +test_expect_success 'git rebase -i (skip)' '
> +	git reset --hard D &&
> +	clear_hook_input &&
> +	FAKE_LINES="2" test_must_fail git rebase -i --onto A B &&

and this

> ...
> +test_expect_success 'git rebase -i (squash)' '
> +	git reset --hard D &&
> +	clear_hook_input &&
> +	FAKE_LINES="1 squash 2" test_must_fail git rebase -i --onto A B &&

and this need to be fixed to something like

	( FAKE_LINES=... &&
          export FAKE_LINES &&
          test_must_fail git ... ) &&

for Bourne-shell portability.  test_must_fail is a shell function and the
usual one-shot-assignment-to-export rule does not apply.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]