Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: >> Yuck. If you know what needs to be done, do that before other poeple add >> more options, please. > > *shrug* > > I was trying to be smart and save a call to git_config() when we know > we don't care about the config anyway. After all it does read a bunch > of files. You can set a flag to skip reading the trees (which is the expensive part) you know you are not going to use to optimize out the expensive part of the code, no? >> Perhaps I am not reading your code right in which case this part needs a >> bit more commenting? > > The catch is in the '&& t->ref'. Ahh, Ok, so that was what I didn't see. Perhaps it needs to say t->ref is set only under such and such conditions. I am reasonably sure the next person who needs to change this part of the code would appreciate such a comment and that person may even be you 3 months from now. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html