Hi, On Tue, 23 Feb 2010, Heiko Voigt wrote: > On Tue, Feb 23, 2010 at 01:04:00AM +0100, Johannes Schindelin wrote: > > > On Mon, 22 Feb 2010, Giuseppe Bilotta wrote: > > > > > git-submodule takes care of clearing GIT_DIR whenever it operates on > > > a submodule index or configuration, but forgot to unset > > > GIT_WORK_TREE before operating on the submodule worktree, which > > > would lead to failures when GIT_WORK_TREE was set. > > > > > > This only happened in very unusual contexts such as operating on the > > > main worktree from outside of it, but since "git-gui: set GIT_DIR > > > and GIT_WORK_TREE after setup" (a9fa11fe5bd5978bb) such failures > > > could also be provoked by invoking an external tool such as "git > > > submodule update" from the Git GUI in a standard setup. > > > > Heiko, would you say that this patch is an elegant solution to the > > problem you reported? If so, would you please pull it to > > 4msysgit.git's devel? > > I would like to leave the patch cooking a little more. Yes, that matches my feeling. Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html