On Tue, Feb 23, 2010 at 12:29:03AM +0100, Giuseppe Bilotta wrote: > On Mon, Feb 22, 2010 at 11:38 PM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote: > > On Mon, Feb 22, 2010 at 04:18:11PM +0100, Giuseppe Bilotta wrote: > >> On Mon, Feb 22, 2010 at 9:27 AM, Matthieu Moy > >> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > >> > Hi, > >> > > >> > In "git gui blame", right-clicking on the left fringe and chosing > >> > "Show History Context" in the context-menu doesn't work for me in the > >> > latest git. It says: > >> > > >> > couldn't change working directory to "": no such file or directory > >> > >> Definitely my fault. _gitworktree was not being set up correctly when > >> support for bare repositories was enabled and the repo was not bare > >> (like in the blame case). Patch incoming, can you see if it does the > >> job for you? It seems to fix it here. > > > > Isn't this the same bug as this one fixes: > > > > http://article.gmane.org/gmane.comp.version-control.git/140288 > > > > cheers Heiko > > Interesting, I missed that patch. However, I strongly suspect that > patch is not correct, since in that case the setup of gitworktree is > done before checking for bareness, meaning that when working in > somerepo.git (bare repo) for which the config flag is not set, it > might misdetect the situation as being in the non-bare case. I believe > my fix to be more correct in this regard. Good to know. I already picked that one into my private repo and did not experience any problems with it, but that might be due to the fact that I have never tried to open git gui on bare repos. cheers Heiko -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html