Matthieu Moy <Matthieu.Moy@xxxxxxx> writes:
> gitmkstemps emulates the behavior of mkstemps, which is usually used
> to create files in a shared directory like /tmp/, hence, it creates
> files with permission 0600. But we use it also to create pack files,
> which do not need this protection.
... and the conclusion is???
Add git_mkstemps_mode() that allows us to specify the desired
mode, and make git_mkstemps() a wrapper that always uses 0600
to call it. Later we will use git_mkstemps_mode() when creating
pack files.
Without it, it sounds as if "so we change it not to do 0600 because I only
care about packfile creation, and do not care about future bugs when
people assume that git_mkstemps() behaves just like mkstemps()", but that
is not what you did.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html