Junio C Hamano <gitster@xxxxxxxxx> writes: > By not using mkstemp() from the platform but having our own would allow us > to not even worry about this issue (this can be seen by the removal of a > call to umask() in [PATCH 4/4]). Exactly. BTW, we probably want to do the same for object files. The problem is less important since object files are created 0444, and therefore do not break ACLs, but that would at least increase consistancy a bit. Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > - > + /* > + * we let the umask do it's job, don't try to be more > + * restrictive. > + */ > + int mode = 0666; Actually, it may be safer to put 0444 here. With my patch, git still creates read-only pack files, but to be honnest, I don't understand which piece of code cuts the 'w' bit! New patch serie comming with additional patches for the first point, and a corrected [PATCH 4] for the second. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html