Re: [PATCH v3 3/5] Move offset_1st_component() to path.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyễn Thái Ngọc Duy schrieb:
> is_dir_sep() or even use your previous implementation of is_root_path > (because this implementation is a bit cryptic).
  >
> But if the new callers of this function will only pass the results of > normalize_path_copy() and getcwd() (both return only forward-slashes on > Windows), then I'm fine with this version. Do they?

  They do. But future-proofing can never be a bad thing.

Thanks, but...

+int offset_1st_component(const char *path)
+{
+	int len = 0;
+	if (has_dos_drive_prefix(path))
+		len += 2;
+	if (is_dir_sep(path[len]))
+		return len++;

oops, does this work at all for you? You must not have 'return' here.

+	return len;
+}

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]