On Sun, Feb 14, 2010 at 10:34:20PM -0800, Junio C Hamano wrote: > > I can't remember the exact details of why the originals were not > > removed, though (I think I complained about it once before, and there > > was some technical reason, but I don't recall now). Daniel (cc'd) might > > remember more. > > Also the names of these functions probably need to be made more specific > so that people not so familiar with the transport code can tell that they > are from "transport" family. The names didn't matter much while they were > file scope static, but this series changes that. Actually, I wonder if we can simply get rid of some of the calls in send-pack. I think that the code in send-pack isn't even called anymore via "git push"; it only gets called when you call send-pack directly. And arguably send-pack as plumbing shouldn't be generating all sorts of user-facing output. But it is a behavior change. I wonder if anybody actually calls send-pack directly anymore. It seems like even scripts use "git push" because of the transport agnosticism. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html