On Sun, Feb 14, 2010 at 09:27:40PM +0000, Michael Lukashov wrote: > The following functions are duplicated: > > verify_remote_names > update_tracking_ref > print_ref_status > status_abbrev > print_ok_ref_status > print_one_push_status > refs_pushed > print_push_status > > Signed-off-by: Michael Lukashov <michael.lukashov@xxxxxxxxx> > --- > builtin-send-pack.c | 89 ++++++++++++++---------- > send-pack.h | 20 +++++ > transport.c | 196 --------------------------------------------------- I think this is backwards. The versions in send-pack were there first, and then were ported to transport.c so that other transports could benefit from them. And that is where they should ultimately be. I can't remember the exact details of why the originals were not removed, though (I think I complained about it once before, and there was some technical reason, but I don't recall now). Daniel (cc'd) might remember more. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html