Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > And even if you could be certain, a hint is missing that strbuf_read(), > its name notwithstanding, does not read NUL-terminated strings. Oh, and > the size is just a hint for the initial size, and it reads until EOF. That > has to be said in the commit message. It is healthy to ask for explanation, especially when the patch cannot justify itself by reading only the diff but reviewer needs to check the surrounding code. I however think you are asking a little too much in this particular case. That strbuf_read() code is exactly the same as in used for "reading from pipe and we don't know how big it is" case in the original code. You can see it in the lines deleted by the patch. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html