Hi, On Sun, 14 Feb 2010, Dmitry Potapov wrote: > + if (strbuf_read(&sbuf, fd, 4096) >= 0) How certain are you at this point that all of fd's contents fit into your memory? And even if you could be certain, a hint is missing that strbuf_read(), its name notwithstanding, does not read NUL-terminated strings. Oh, and the size is just a hint for the initial size, and it reads until EOF. That has to be said in the commit message. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html