Hi, On Wed, Feb 10, 2010 at 1:55 PM, Larry D'Anna <larry@xxxxxxxxxxxxxx> wrote: > * Jeff King (peff@xxxxxxxx) [100210 00:41]: >> I had initially endorsed it, but now I am having second thoughts. >> Especially if the "usual" calling convention is to redirect stderr as >> above, then we are probably missing out on any useful error messages >> that accompany a failure return, anyway. So maybe the sane thing to do >> is to leave the exit code alone, and include a --porcelain output line >> that either says "Everything was OK, see individual ref status" or "We >> couldn't even talk to the other side". Then the status code is >> irrelevant, and stdout contains all of the useful information (and if >> you don't get an error or OK message, you know there was some >> serious error like a broken git installation). > > That serves my purposes as well as the exit code would. Is this the consensus? does this mean the ugly return status mangling patch (git-push: make git push --dry-run --porcelain exit with status 0 even if updates will be rejected) would be dropped? If so, I'm all for it. =p -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html