Larry D'Anna <larry@xxxxxxxxxxxxxx> writes: > * don't emit long explanatory message about non-fast-forward updates. This makes sense as a goal, but at the same time as an implementation it would be cleaner to flip "advice" off under --porcelain, instead of doing "s/if (advice_blah)/if (advice_blah && !porcelain)/;". This is doubly important if you consider longer term maintainability. I do not want to see the next person who tries to add new advice messages to copy and paste the long if() statement you added in this patch. > * send "To dest" lines to standard out so whoever is reading standard > out knows which ref updates went to which remotes. Makes sense. s/standard out/the standard output/, and s/reading .*knows/reading from the process knows/, perhaps. > * only send the "Everything up-to-date" line if verbose. Don't you want to send this also to stdout? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html