On Fri, Feb 05, 2010 at 06:47:48PM +0700, Nguyễn Thái Ngọc Duy wrote: > When GIT_DIR environment variable is not specified, .git will be > searched if a repository is needed. Currently this can be done in two > places: setup_git_directory_gently() and setup_git_env(). > > The one in setup_git_env() is no longer correct and should IMHO have > been removed since the introduction of setup_git_directory_gently() in > d288a70. Having two ways of auto detection may lead to obscure errors > because .git may be misdetected by setup_git_env(), > automatically called via git_path(), which is all over the place. > > This patch makes setup_git_env() die if GIT_DIR is not explictly > set. That's setup_git_directory_gently()'s job. If you ever want to > touch things inside $GIT_DIR, you should have already called > setup_git_directory_gently(). > > This patch breaks commands (in a good way) and obviously not for > mainline. I still have to go through "make test" to see how many are > impacted. But I think this is a good change. Am I missing something? It has been a while since I looked at this code, but I think this is a good direction forward. I remember trying something like this and getting discouraged at all of the ensuing breakage. So if you can track down all of the fallouts and fix them, I think we will be better off in the long run. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html