On Thu, Feb 04, 2010 at 07:41:40PM -0500, Larry D'Anna wrote:
> Having it go to standard output interferes with git-push --porcelain.
> ---
> builtin-push.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/builtin-push.c b/builtin-push.c
> index 5633f0a..0a27072 100644
> --- a/builtin-push.c
> +++ b/builtin-push.c
> @@ -124,9 +124,9 @@ static int push_with_options(struct transport *transport, int flags)
> return 0;
>
> if (nonfastforward && advice_push_nonfastforward) {
> - printf("To prevent you from losing history, non-fast-forward updates were rejected\n"
> - "Merge the remote changes before pushing again. See the 'Note about\n"
> - "fast-forwards' section of 'git push --help' for details.\n");
> + fprintf(stderr, "To prevent you from losing history, non-fast-forward updates were rejected\n"
> + "Merge the remote changes before pushing again. See the 'Note about\n"
> + "fast-forwards' section of 'git push --help' for details.\n");
I agree that stderr is a more sensible place for such a message to go,
but shouldn't the porcelain output format just suppress it entirely? The
whole point of it is to be machine readable, and this text is
a. formatted for humans
b. totally redundant with the machine-readable information presented
earlier
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html