Re: [BUG] - "git commit --amend" commits, when exiting the editor with no changes written

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 2 Feb 2010, Eugene Sajine wrote:

[somebody wrote this, I suspect it was Wincent]
>
> > Why should Git care about how you exited from your EDITOR? All it 
> > should care about is the contents of the commit message, and the exit 
> > code of the editor.
> 
> It doesn't matter which editor is used. The only thing that matters is 
> that you saving or not saving on exit from editor. If not saving - abort 
> the action.

No. If not saving, then it means that the user was fine with the message 
as-is.

Remember, --amend is usually for amending the _content_ of the patch, not 
so much the message.

Of course, you could come up with wonderfully complicated strategies such 
as "if nothing was added, then an unmodified commit message means 'abort', 
else it means 'go ahead'", but I hope that you agree that this would be 
very bad from the users' POV: it would be utterly confusing.

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]