Re: [PATCH 3/3] rebase -i: Export GIT_AUTHOR_* variables explicitly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 22 Jan 2010, Michael Haggerty wrote:

> As pointed out on the mailing list, one-shot shell variable exports do
> not necessarily work with shell functions.  So export the GIT_AUTHOR_*
> variables explicitly using "export".

This one's a bit hairy; I really was not sure about unintended side 
effects, that is why I avoided the export.

Just imagine, for example, some git commit --amend which forgets to set 
the author information; I am not saying that this is happening, but I 
cannot be sure, because every possible code path to a git 
commit/commit-tree has to be checked, and this does not mean that future 
patches will not introduce such broken code, either.

It might also be possible that some people scripted rebase -i with a 
custom "editor" as in the tests (I have done so in the past).  They would 
be affected.

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]