David Rydh schrieb: > diff --git a/builtin-mv.c b/builtin-mv.c > index 8247186..1c1f8be 100644 > --- a/builtin-mv.c > +++ b/builtin-mv.c > @@ -27,7 +27,7 @@ static const char **copy_pathspec(const char *prefix, const char **pathspec, > if (length > 0 && is_dir_sep(result[i][length - 1])) > result[i] = xmemdupz(result[i], length - 1); > if (base_name) > - result[i] = basename((char *)result[i]); > + result[i] = xstrdup(basename((char *)result[i])); > } > return get_pathspec(prefix, result); > } We are already leaking memory of magnitude O(argc*length of file names), and IMO, this new leak of the same magnitude doesn't hurt. If you want to avoid it, you can set NO_LIBGEN_H in Makefile. The other changes in this patch should really be a separate patch. They do not fix an immediate problem, right? -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html