Re: [PATCH] git-mv: Fix error with multiple sources.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"David Rydh" <dary@xxxxxxxxxxxxxxxxx> writes:

>  		if (!is_absolute_path(given_config_file) && prefix)
> -			config_exclusive_filename = prefix_filename(prefix,
> +			config_exclusive_filename = xstrdup(prefix_filename(prefix,
>  								    strlen(prefix),
> -								    argv[2]);
> +									argv[2]));

Broken indentation on the last two lines.

Other than that, you use strdup without free-ing the result. Probably
not so serious, but it may be cleaner to actually call free, or to
explain why you don't (in commit message).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]