On Wed, Jan 20, 2010 at 02:07:47PM -0800, Junio C Hamano wrote: > > - if (fmt != CMIT_FMT_ONELINE && fmt != CMIT_FMT_RAW) > > + if (context->show_notes || > > + (fmt != CMIT_FMT_ONELINE && fmt != CMIT_FMT_RAW)) > > get_commit_notes(commit, sb, encoding, > > NOTES_SHOW_HEADER | NOTES_INDENT); > > Heh, without this hunk I would have thought Peff and Gitster were the same > person ;-). > > Once you introduce --no-notes, the above condition would not work well. Yeah, I know, or I would have just added the 2 lines for --no-show-notes. :) I think your patch is better; I'll comment on it separately. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html