Luben Tuikov wrote: > --- Jakub Narebski <jnareb@xxxxxxxxx> wrote: > > * Improve blame view, making use of --porcelain option to git-blame (for > > later). Perhaps change blame view from table based one to div based one. > > > Use different colors for different commits (graph coloring problem). > > Oh, no please no. > > Why do you think I left the color list as a list? I did try to use > more colors when I wrote it, and it was ugly as h3ll and very distracting > when doing real work. So I ended up with the two color (shades) we have > now and this is what I submitted. > > Also, any kind of "graph coloring problem" would make blame slow. One of ideas (without having some nice _mathematical_ solution, i.e. not having for to try and check different coloring but calculating coloring, of a blame graph coloring problem[*1*]) was to use few colors, 3, 6, 8 based on some hash of sha1 of commit (for example first character) plus alternating "darkness" of those colors to ensure that neighbours would have different colors. Another was to use first 6 characters of sha1 as a color, then flatten the color to suitable for background (perhaps also with some kind of ensuring that neigbour blames would have different color). Junio idea of basing color/brighness (of some part of blame output at least) on the _age_ of region (perhaps using two altrenating _colors_) has also it's merit. Nevertheless, such change would be preceded by an RFC, and discussion. > In any way, if you/someone does implement this "coloring" can you please > make it an option, because I'll never turn it on. Thanks! Not a problem to make blame coloring a feature. Footnotes: [*1*] Blame graph coloring problem: 1) regions blamed on the same commit should have the same color 2) neighbour blame regions should have different colors. -- Jakub Narebski Poland - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html