Petr Baudis wrote:
> Dear diary, on Sat, Oct 07, 2006 at 12:06:31PM CEST, I got a letter
> where Jakub Narebski <jnareb@xxxxxxxxx> said that...
>> >>>> + $str =~ s/\r/\\r/g;
>> >>>
>> >>> \r? Not \n?
>> >>
>> >> Yes, \r, not \n.
>> >
>> > \r to \\r? Not to \\\r?
>>
>> We want "\r" in suggested filename, not "\
>> " I think, so it is "\\r".
>
> Oh, yes. Lubin wants. It looked sane until I've read it as you
> explicitly wrote it. ;-)
>
> That's "obviously" wrong. In qtext, \r means just r, no special
> interpretation is done. So we indeed _would_ want "\
> ". Which is of course a nice trap for buggy browsers so in fact we
> obviously do not want that. I think it's not wort the potential problems
> to try to carry newlines in the header, so I would just replace that
> line with
>
> $str =~ s/[\n\r]/_/g;
>
> as per Junio's suggestion.
Bu the way, using the following script:
-- >8 --
#!/usr/bin/perl
use strict;
use warnings;
use CGI qw(:standard :escapeHTML -nosticky);
binmode STDOUT, ':utf8';
our $cgi = new CGI;
print $cgi->header(
-type => 'text/plain',
-charset => 'utf-8',
-content_disposition => 'inline; filename="test\".\\"test\\n.\\\n"');
print "TEST\n";
-- >8 --
I've checked that at least Mozilla 1.7.12 wants to using "\n"
in file name instead of literal eoln.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html