Junio C Hamano wrote:
> Luben Tuikov <ltuikov@xxxxxxxxx> writes:
>
>>>> +# Convert a string (e.g. a filename) into qtext as defined
>>>> +# in RFC 822, from RFC 2183. To be used by Content-Disposition.
>>>> +sub to_qtext {
>>>> + my $str = shift;
>>>> + $str =~ s/\\/\\\\/g;
>>>> + $str =~ s/\"/\\\"/g;
Here probably it could be
$str =~ s/"/\\"/g;
>>>> + $str =~ s/\r/\\r/g;
>>>
>>> \r? Not \n?
>>
>> Yes, \r, not \n.
>
> \r to \\r? Not to \\\r?
We want "\r" in suggested filename, not "\
" I think, so it is "\\r".
Otherwise we could use simplier
$str =~ s/([\\"\r])/\\\1/g;
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html