Jakub Narebski <jnareb@xxxxxxxxx> writes:
> Junio C Hamano wrote:
>
>> Luben Tuikov <ltuikov@xxxxxxxxx> writes:
>>
>>>>> +# Convert a string (e.g. a filename) into qtext as defined
>>>>> +# in RFC 822, from RFC 2183. To be used by Content-Disposition.
>>>>> +sub to_qtext {
>>>>> + my $str = shift;
>>>>> + $str =~ s/\\/\\\\/g;
>>>>> + $str =~ s/\"/\\\"/g;
>
> Here probably it could be
> $str =~ s/"/\\"/g;
>
>>>>> + $str =~ s/\r/\\r/g;
>>>>
>>>> \r? Not \n?
>>>
>>> Yes, \r, not \n.
>>
>> \r to \\r? Not to \\\r?
>
> We want "\r" in suggested filename, not "\
> " I think, so it is "\\r".
Is that what you guys are attempting to achieve?
If we are trying to suggest a filename that is safe by avoiding
certain characters, I suspect leaving a backslash and dq as-is
is just as bad as leaving a CR in. So if that is the goal here,
I think it might be better and a lot simpler to just replace
each run of bytes not in Portable Filename Character Set with an
underscore '_'.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html