Hi, On Wed, Dec 9, 2009 at 1:17 AM, Daniel Barkalow <barkalow@xxxxxxxxxxxx> wrote: > On Tue, 8 Dec 2009, Tay Ray Chuan wrote: > >> Move the logic that detects up-to-date and non-fast-forward refs to a >> new function in remote.[ch], set_ref_status_for_push(). > > Is there some reason to not have set_ref_status_for_push() be static in > transport.c now? (Sorry for not suggesting this before.) it can't be static, because builtin-send-pack.c::main() needs it too. > Other than that, it looks good to me. Thanks. -- Cheers, Ray Chuan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html