On Tue, 8 Dec 2009, Tay Ray Chuan wrote: > Move the logic that detects up-to-date and non-fast-forward refs to a > new function in remote.[ch], set_ref_status_for_push(). Is there some reason to not have set_ref_status_for_push() be static in transport.c now? (Sorry for not suggesting this before.) Other than that, it looks good to me. I think it might be a good idea to have it generate a peer ref for refs that don't have one when mirror is used, which would eliminate a couple more lines, but there's no reason that has to be done in the same patch. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html