Re: [RFC PATCH v2 2/2] MSVC: Fix an "incompatible pointer types" compiler warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Dienstag, 8. Dezember 2009, Ramsay Jones wrote:
>     30	#define stat _stat64
>     31	int mingw_lstat(const char *file_name, struct stat *buf);
>     32	int mingw_fstat(int fd, struct stat *buf);
>     33	#define fstat mingw_fstat
>     34	#define lstat mingw_lstat
>     35	#define _stat64(x,y) mingw_lstat(x,y)
>     36	#define ALREADY_DECLARED_STAT_FUNCS
>     37
>     38	#include "compat/mingw.h"
>     39
>     40	#undef ALREADY_DECLARED_STAT_FUNCS
>
> This works fine, *provided* you do not need to compile with
> -D_USE_32BIT_TIME_T, which would produce this warning:
>
>     ...mingw.c(223) : warning C4133: 'function' : incompatible types - \
>     from '_stat64 *' to '_stat32i64 *'
>
> This would actually be *worse* than the original code, since the struct
> _stat64 would not have the same "shape" as the struct _stat32i64; ...

To cut this short: According to your explanations, using -D_USE_32BIT_TIME_T 
with MSVC is bad. Please reroll without references to _USE_32BIT_TIME_T.

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]