On Thu, Dec 3, 2009 at 8:30 PM, Alex Chiang <achiang@xxxxxx> wrote:
> * Karl Wiberg <kha@xxxxxxxxxxx>:
>
> > On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang <achiang@xxxxxx> wrote:
> >
> > > + for (p, n) in zip(patches, range(1, total_nr + 1)):
> > > + msg_id = __send_message('patch', tmpl, options, p, n, total_nr, ref_id)
> >
> > Can be written as
> >
> > for (n, p) in enumerate(patches):
> >
> > if you use n + 1 instead of n in the loop body.
>
> That is a little cleaner, but I decided to keep it as zip(). Why?
> Because using n + 1 in the loop body will push that line past 80
> columns. ;)
>
> It's also the original code (albeit with a simple variable rename).
>
> I know this isn't the kernel, and that there are plenty of other
> lines that are 80+ characters, but if you can keep it short, why
> not?
Oh, I fully favor keeping lines within the 80 columns allotted to us
by the ancestors---I just didn't realize it was going to be a problem
here.
In general, though, programmer time is worth optimizing for, and
thinking through exactly what zip(patches, range(1, total_nr + 1))
means (and getting it right!) is a small but not insignificant cost
every time someone reads the code.
--
Karl Wiberg, kha@xxxxxxxxxxx
subrabbit.wordpress.com
www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html