* Karl Wiberg <kha@xxxxxxxxxxx>:
> Just pointing out a couple of Python tricks you might've wanted to
> use. No need to update the patch, though.
>
> On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang <achiang@xxxxxx> wrote:
>
> > + (patch_nr, total_nr) = (args[1], args[2])
>
> Can be written as
>
> (patch_nr, total_nr) = args[1:3]
Thanks, I did it this way.
> or, if args[2] is the last element of the list (which it isn't in this
> case?),
>
> (patch_nr, total_nr) = args[1:]
No, ref_id is the last arg, so that won't work.
> > + for (p, n) in zip(patches, range(1, total_nr + 1)):
> > + msg_id = __send_message('patch', tmpl, options, p, n, total_nr, ref_id)
>
> Can be written as
>
> for (n, p) in enumerate(patches):
>
> if you use n + 1 instead of n in the loop body.
That is a little cleaner, but I decided to keep it as zip(). Why?
Because using n + 1 in the loop body will push that line past 80
columns. ;)
It's also the original code (albeit with a simple variable
rename).
I know this isn't the kernel, and that there are plenty of other
lines that are 80+ characters, but if you can keep it short, why
not?
Thanks,
/ac
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html