Re: [PATCH] reset: add --quiet option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:

> On Mon, Nov 30, 2009 at 11:45 PM, Stephen Boyd <bebarino@xxxxxxxxx> wrote:
>> If you're already touching the line why not just do it once? I agree a
>> follow-up patch to cover the other commands would be good.
>
> Because the less trivial the patches, the less luck I have of getting
> them applied :)

Well, the name of the game is not "let me have more commits under my name
in a well known project".  It is "let's work together to make the system
better without stepping on each other's toes and without introducing
unintended side effects".

I actually do not think it is the complexity that matters.  It largely
depends on what other patches are in flight that may have interactions,
and if the change is suitable for the phase of the cycle.

> Anyway, I sent a patch to use OPT__QUIET directly in two places.

Yeah, I saw it and queued it to 'pu'.  Thanks.

We _might_ want to think about doing something about the lossage of "long
messages" by this conversion, and we may end up updating OPT__QUIET() to
allow its users supply messages that are more suitable than the default
one, but I do not want to see such a change to parse-options before 1.6.6
happens on the 'master' branch, as I do not have infinite mental
bandwidth.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]