Re: [PATCH] reset: add --quiet option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2009-11-29 at 12:58 +0200, Felipe Contreras wrote:
> diff --git a/builtin-reset.c b/builtin-reset.c
> index 73e6022..c0127c4 100644
> --- a/builtin-reset.c
> +++ b/builtin-reset.c
> @@ -209,7 +209,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
>  				"reset HEAD, index and working tree", HARD),
>  		OPT_SET_INT(0, "merge", &reset_type,
>  				"reset HEAD, index and working tree", MERGE),
> -		OPT_BOOLEAN('q', NULL, &quiet,
> +		OPT_BOOLEAN('q', "quiet", &quiet,
>  				"disable showing new HEAD in hard reset and progress message"),
>  		OPT_BOOLEAN('p', "patch", &patch_mode, "select hunks interactively"),
>  		OPT_END()

Why not just OPT__QUIET? We lose the specific help string but it's
possible that what quiet is silencing will change in the future.

Maybe you could move the help string to the documentation if you want to
save it.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]