On Tue, Dec 01, 2009 at 12:42:29PM -0800, Junio C Hamano wrote:
>
> It is somewhat unfortunate that a few changes I liked (e.g. the "debug"
> bit), even though it was somewhat painful to read them due to coding style
> differences, were not at the beginning of the series but instead buried
> after changes that are much bigger and controversial (e.g. [6/8]).
Funny, I considered some other stuff in series much more controversial than
the 6/8 one.
And 6/8 large? Its smallest (source code files only) or second smallest (all
files) in number of line changes in the series.
If one looks at 6/8, what it basically does is:
- Alias remote-curl as remote-{http,ftp}{,s} since the special case dispatch
rules are no more (.gitignore + makefile).
- Remove the special case dispatch rules (transport.c).
Taking diffstat of fixed version of 6/8 (I'll send that later as second round,
possibly with additional fixes):
.gitignore | 4 ++++
Makefile | 19 +++++++++++++++++++
transport.c | 8 --------
3 files changed, 23 insertions(+), 8 deletions(-)
And here's what it does to transport.c:
- } else if (!prefixcmp(url, "http://";)
- || !prefixcmp(url, "https://";)
- || !prefixcmp(url, "ftp://";)) {
- /* These three are just plain special. */
- transport_helper_init(ret, "curl");
-#ifdef NO_CURL
- error("git was compiled without libcurl support.");
-#endif
That's 8 lines killed in transport.c, 4 new binary aliases (yeah, I'm not that
good with makefiles plus this seems to be somewhat nasty case).
-Ilari
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html